Skip to content

{session, memory}: simplify duplicate logic in the new service through refactoring #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

{session, memory}: simplify duplicate logic in the new service through refactoring #758

wants to merge 7 commits into from

Conversation

@nomand-zc
Copy link
Contributor

@nomand-zc nomand-zc commented Nov 27, 2025

No description provided.

@codecov
Copy link

codecov bot commented Nov 27, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.83170%. Comparing base (86472bd) to head (1e50458).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
memory/redis/service.go 85.71429% 1 Missing ⚠️
session/postgres/service.go 88.88889% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main        #758         +/-   ##
===================================================
+ Coverage   87.65179%   87.83170%   +0.17990%     
===================================================
  Files            281         281                 
  Lines          36564       36554         -10     
===================================================
+ Hits           32049       32106         +57     
+ Misses          2934        2864         -70     
- Partials        1581        1584          +3
Flag Coverage Δ
unittests 87.83170% <96.00000%> (+0.17990%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nomand-zc nomand-zc changed the title session/redis: refactor new service logic [WIP]session/redis: refactor new service logic Nov 27, 2025
@nomand-zc nomand-zc changed the title [WIP]session/redis: refactor new service logic [WIP]{session, memory}: refactor new service logic Nov 27, 2025
@nomand-zc nomand-zc changed the title [WIP]{session, memory}: refactor new service logic [WIP]{session, memory}: simplify duplicate logic in the new service through refactoring Nov 27, 2025
@nomand-zc nomand-zc changed the title [WIP]{session, memory}: simplify duplicate logic in the new service through refactoring {session, memory}: simplify duplicate logic in the new service through refactoring Nov 28, 2025
Rememorio
Rememorio reviewed Nov 28, 2025
View reviewed changes
@nomand-zc nomand-zc requested a review from Rememorio November 28, 2025 09:44
Rememorio
Rememorio approved these changes Nov 28, 2025
View reviewed changes
Copy link
Contributor

@Rememorio Rememorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rememorio Rememorio Rememorio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nomand-zc @Rememorio